Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update getActivitiesById and getLastActivitiesForMembers #2641

Merged
merged 10 commits into from
Oct 9, 2024
Merged

update getActivitiesById and getLastActivitiesForMembers #2641

merged 10 commits into from
Oct 9, 2024

Conversation

skwowet
Copy link
Member

@skwowet skwowet commented Oct 8, 2024 •
edited
Loading

Changes proposed ✍️

What

copilot:summary
​
copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet
Copy link
Member Author

skwowet commented Oct 8, 2024 •
edited
Loading

@themarolt @loicsaintroch We basically use the queryActivities method inside getLastActivitiesForMembers, and right now it throws an error because no segmentId or tenantId is passed, as they're required in queryActivities here:

https://github.com/CrowdDotDev/crowd.dev/blob/improvement/questdb-improvements/services/libs/data-access-layer/src/activities/sql.ts#L463-L465

Let me know the design for the method, and we can either remove the condition or send the expected params!

@skwowet skwowet changed the title rm tenantId and segmentId check in queryActivities update getActivitiesById and getLastActivitiesForMembers with tenantId para Oct 8, 2024
@skwowet skwowet changed the title update getActivitiesById and getLastActivitiesForMembers with tenantId para update getActivitiesById and getLastActivitiesForMembers Oct 8, 2024
@skwowet skwowet merged commit 64af876 into improvement/questdb-improvements Oct 9, 2024
6 of 8 checks passed
@skwowet skwowet deleted the bugfix/getLastActivitiesForMembers branch October 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarolt themarolt themarolt approved these changes

@loicsaintroch loicsaintroch Awaiting requested review from loicsaintroch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skwowet @themarolt